Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Library helper functions need to be properly namespaced #109

Closed
ramereth opened this issue Mar 26, 2020 · 0 comments · Fixed by #111
Closed

Library helper functions need to be properly namespaced #109

ramereth opened this issue Mar 26, 2020 · 0 comments · Fixed by #111
Assignees
@ramereth
Labels
Bug Something isn't working Needs Triage Issue is waiting to be categorised

Comments

@ramereth
Copy link
Contributor

🗣️ Foreword

The library helper functions are global and conflict with other cookbooks such as apache2.

👻 Brief Description

Some helper functions such as lock_dir conflict with the apache2 cookbook which can cause problems when both cookbooks are included in a run list. The primary issue is that the helper functions are not properly namespaced like the apache2 cookbook is.

The resolution is to properly namespace the helper functions so they don't get pulled in globally.

🥞 Cookbook version

6.0.0

👩‍🍳 Chef-Infra Version

15

🎩 Platform details

Ubuntu/Debian/CentOS
@ramereth ramereth added Type: Tech Debt Bug Something isn't working Needs Triage Issue is waiting to be categorised labels Mar 26, 2020
@ramereth ramereth self-assigned this Mar 26, 2020
ramereth added a commit that referenced this issue Apr 4, 2020
@ramereth
Move library helper functions into a Memcached::Helpers namespace
c78c2ba 
This resolves #109.
@ramereth ramereth mentioned this issue Apr 4, 2020
Merged
3 tasks
ramereth added a commit that referenced this issue Apr 5, 2020
@ramereth
Move library helper functions into a Memcached::Helpers namespace
5854755 
This resolves #109.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ramereth ramereth

Labels
Bug Something isn't working Needs Triage Issue is waiting to be categorised
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cleanup and some refactoring sous-chefs/memcached
1 participant
@ramereth