Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dangerfile should use failure instead of fail #110

Closed
xorima opened this issue Oct 7, 2019 · 5 comments
Closed

Dangerfile should use failure instead of fail #110

xorima opened this issue Oct 7, 2019 · 5 comments

Comments

@xorima
Copy link
Contributor

xorima commented Oct 7, 2019

On the repo, ensure that Dangerfile matches https://github.com/sous-chefs/repo-management/blob/master/Dangerfile

This was referenced Oct 9, 2019
This was referenced Oct 9, 2019
@JohnRoesler
Copy link
Contributor

@tas50 should this now be raise? I've seen it in a few prs

@tas50
Copy link
Contributor

tas50 commented Dec 10, 2019

Rubocop is going to want raise. If that's not going to work with Danger and CI then we should get that pushed out in .rubocop.yml files

@JohnRoesler
Copy link
Contributor

@xorima 👆

@xorima
Copy link
Contributor Author

xorima commented Dec 11, 2019

Ok I will add this to my todo list today

@xorima
Copy link
Contributor Author

xorima commented Dec 11, 2019

Closing now as every single cookbook repo is done, every single issue is now closed.

@xorima xorima closed this as completed Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants