Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[COOK-3674] Fix an issue where the root password is not set properly …
…with a non-default `data_dir` Signed-off-by: Seth Vargo <sethvargo@gmail.com>
- Loading branch information
Showing
2 changed files
with
40 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e412e32
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This, much like my beef with the postgres book; thisnow has the same issue. Wrapper books can't undo an :immediately notification, but they can choose to notify immediately if they need to. So we're stuck in situations where wrapper books are failing because my.conf is dropped, possibly incorrectly in the lib or app book , or user changing attritues and the service will never start. No amount of updating books and running chef-client then can fix that until you log into the server manually.
e412e32
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to claco. :immediately makes me cry and breaks my codes.
e412e32
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this redundant anyway? The EXACT same template update occurs under the EXACT same conditional higher up in the code. The only difference the notification is immediately instead of delayed.
e412e32
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WMeldon Not sure who that's directed at (and for future lurkers) Here's what I mean about the problem with the cookbook changing to :immediately, dropping custom templates in the wrapper book, order of operations, etc: https://tickets.opscode.com/browse/COOK-3427