Update 57 pw init #584
Closed
Update 57 pw init #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also removed fedora-28 from 56 yum distros, latest there was 24
|
@tealice would you fancy resolving the conflicts and working to get this merged in? |
|
Hey @tealice Any chance you could fix the issues with .kitchen so we can get tests passing etc? Thanks! |
xorima
added
Bug
gsomoza
pushed a commit
to gsomoza/mysql
that referenced
this pull request
May 14, 2020
This is exactly the same as sous-chefs#584 but squashed without the MySQL 8.0 changes, which should make it much easier to merge.
gsomoza
pushed a commit
to gsomoza/mysql
that referenced
this pull request
May 14, 2020
This is exactly the same as sous-chefs#584 but squashed without the MySQL 8.0 changes, which should make it much easier to merge.
3 tasks
|
Hey @tealice can you update your fork and fix the kitchen conflicts and we can ship this! Thanks, |
gsomoza
pushed a commit
to gsomoza/mysql
that referenced
this pull request
May 14, 2020
…ous-chefs#584 but squashed without the MySQL 8.0changes, which should make it much easier to merge.
|
@tealice reping |
3 tasks
|
Closing due to inactivity. If this is still wanted please reopen or open another pull request. Alternatively drop by the #sous-chefs channel on the Chef Community Slack and we'll be happy to help! Thanks, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
mysql-systemd-startscript under/usr/share/mysql/8.0and didn't want to include too many changes here.v56plusandv57plusmethods to useGem::Versioninit_records_scriptto set the root password usingALTER USERfor 5.7+, from Patched helpers password setting to work with mysql>=5.7 #518 and the issue linked below.Issues Resolved
Fixes #410
closes #518
Check List
Couple questions:
Should I update the README with which platforms have been tested with Test Kitchen? And not sure if I should add a DCO to any commits (maybe the vplus methods?) since the init_records_script modification was authored by someone else. Thanks!