Bug in services.cfg.erb (services with the hostgroup all missing from the resulting config)

[heaven]

Also the validation could be changed to:

valid = !!service['hostgroup_name'].split(",").
  find { |s| @hostgroups.include?(s) or @search_hostgroups.include?(s) }

[sbotman]

With the new model these checks should not be needed any more. Checkout pull request #319 and feel free to share your thoughts on it.

[heaven]

Hi, for now I only upgraded to 5.3.4 (because of the refactoring in the gem I can't use the most recent version for now). One thing I noticed is that all our services with host group all stopped working. So I had to add:

<%
   hostgroups = @hostgroups | ['all']
%>

And to remove service['hostgroup_name'] == "all" check at all.

[sbotman]

@heaven oke with you if we close this? Because cannot reproduce the problem with latest version. Cheers Sander

[heaven]

@sbotman sure, the problem only exists in versions <= 5.3.4.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.