Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change nginx deps to chef_nginx #510

Merged
merged 2 commits into from Feb 14, 2017
Merged

Change nginx deps to chef_nginx #510

merged 2 commits into from Feb 14, 2017

Conversation

stem
Copy link
Contributor

@stem stem commented Dec 28, 2016

The nginx cookbook is deprecated for the chef_nginx. So this cookbooks should use the supported chef_nginx dependancy.

The nginx cookbook is deprecated for the chef_nginx. So this cookbooks should use the supported chef_nginx dependancy.
@snkutlu
Copy link
Contributor

snkutlu commented Jan 25, 2017

@stem, this also needs to be adjusted in recipe which include nginx::default recipe. Travis CI failure shows the failing recipe as recipes/nginx.rb.

Can you please fix this?

@stem
Copy link
Contributor Author

stem commented Jan 25, 2017

@snkutlu yes of course. I've change the include_recipe and that should be OK.

However, there are multiple offenses detected by Rubocop that are also on master.
Let me know if you want me to change them.

@snkutlu
Copy link
Contributor

snkutlu commented Feb 14, 2017

Thanks.... After merging yours, I will fix them all..

@snkutlu snkutlu merged commit 9074643 into sous-chefs:master Feb 14, 2017
@lock
Copy link

lock bot commented Jul 24, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants