Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node['nginx']['group'] default attribute improperly set #334

Closed
stevenolen opened this issue Mar 15, 2015 · 2 comments
Closed

node['nginx']['group'] default attribute improperly set #334

stevenolen opened this issue Mar 15, 2015 · 2 comments

Comments

@stevenolen
Copy link
Contributor

Noticed this on ubuntu 14.04 & 12.04 (well, based on the logic, it should really happen everywhere) after the commits made in the past day.

https://github.com/miketheman/nginx/blob/master/attributes/default.rb#L73

appears to resolve to {} instead of 'www-data' and instead should be:
default['nginx']['group'] = node['nginx']['group'] || node['nginx']['user']

Submitting PR, but wanted an issue in case further discussion was required..

miketheman added a commit that referenced this issue Mar 15, 2015
fixes #334, default group is set to empty value
@miketheman
Copy link
Contributor

Thanks!

@lock
Copy link

lock bot commented Apr 25, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants