Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Version for Package Installations. #170

Closed
wants to merge 14 commits into from

Conversation

cworsnup13
Copy link

The recipe, as is, will install the latest stable release. It would be a good feature to specify the package version installed.

@aaronbbrown
Copy link
Contributor

Can someone merge this in? @someara maybe? The foodcritic error it is failing on does not seem to have anything to do with this commit.

@@ -24,6 +24,7 @@
# This attribute is in the source.rb file, though we recommend overriding
# attributes by modifying a role, or the node itself.
default['nginx']['version'] = '1.2.9'
default['nginx']['pkg_version'] = '1.4.1-1.el6.ngx'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to make this nil by default to maintain the existing behavior

@miketheman miketheman added this to the Triage milestone Aug 23, 2014
@miketheman
Copy link
Contributor

Closing as this is unmergable.

@miketheman miketheman closed this Mar 14, 2015
@miketheman miketheman removed this from the Triage Round 1 milestone Mar 14, 2015
@lock
Copy link

lock bot commented Apr 25, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants