Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packagecloud apt key rotation not applied #58

Open
robbat2 opened this issue Jan 30, 2019 · 3 comments
Open

Packagecloud apt key rotation not applied #58

robbat2 opened this issue Jan 30, 2019 · 3 comments
Labels
Feature Request Enhancement to existing functionality or new functionality

Comments

@robbat2
Copy link

robbat2 commented Jan 30, 2019

The packagecloud_repo repo only pulls the GPG key during deployment; and does not detect in any way that the key might have been rotated.

To properly solve this, the resource needs to keep the downloaded key, and be able to compare it back against the server copy for updates.

@damacus
Copy link
Member

damacus commented Apr 26, 2023

This would stop the cookbook from being idempotent, as it would change every run. Or at least download the key every run. If you can think of a way of implementing this, we're happy to receive a PR for this 👍🏼

@damacus damacus added the Feature Request Enhancement to existing functionality or new functionality label Apr 26, 2023
@robbat2
Copy link
Author

robbat2 commented Apr 28, 2023

Wow, dead ticket resurrect here.

Do you consider remote_file resource properties use_conditional_get / use_etag / use_last_modified to be sufficiently idempotent?

To use it, you'd have to wire up gpg_url to produce a file that stays on disk after it's imported into the keyring.

@damacus
Copy link
Member

damacus commented May 3, 2023

hah yeah, wading through lost repositories now we've adopted them!

I haven't considered that yet. Are you still using the cookbook? If so, do you fancy giving that a go?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Enhancement to existing functionality or new functionality
Projects
None yet
Development

No branches or pull requests

2 participants