-
-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP7 / Ubuntu 16.04 & PHP-FPM Pool Listen User/Group #169
Conversation
As proposed in sous-chefs/php#169
Refactors attributes and LWRPs to support PHP7. Attributes are set "cascading" beginning at one value and eventually being set to the correct one for the platform and version.
Adds additional config to allow for separate listen users and groups for the pool. Code from PR#155 (https://github.com/chef-cookbooks/php/pull/155/files)
def whyrun_supported? | ||
true | ||
end | ||
|
||
action :discover do | ||
unless exists? | ||
Chef::Log.info("Discovering pear channel #{@new_resource}") | ||
execute "#{node['php']['pear']} channel-discover #{@new_resource.channel_name}" do | ||
r = execute "#{node['php']['pear']} channel-discover #{@new_resource.channel_name}" do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You shouldn't need to do any of the updated_by_last action mess if you use inline resources. The inline resource method handles bubbling up the notifications
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to know. I'll remove the updated by last action code.
* Adds package to help make find correct libraries for compilation in Ubuntu 16.04. * Fixes missing gmp.h file from compilation in Ubuntu 14.04 and 16.04 * Fixes fpm service error for resource.
@ThatGerber
My question is: Do I need to have php5 installed in order to install php7? Am I missing something here? |
@jamescorkran Did you find an answer to your question here? |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This pull request adds support for PHP7 by moving around the order of operations for setting attributes to take into account settings in the upcoming Ubuntu 16.04, moving a few system calls into variables from the LWRP, and updating package names for php in the upcoming Ubuntu LTS 16.04. It also fixes a few foodcritic warnings.
This PR also pulls changes from #155, with updates. It creates a few extra pool configuration variables, allowing the pool listener to differ from the owner, and group to differ from the user. However, attributes have been set to mimic old behavior by default.