Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ubuntu 18: Install libssl-dev instead of libssl1.0-dev #160

Merged
merged 2 commits into from
May 16, 2023
Merged

Ubuntu 18: Install libssl-dev instead of libssl1.0-dev #160

merged 2 commits into from
May 16, 2023

Conversation

SeanSith
Copy link
Contributor

@SeanSith SeanSith commented May 10, 2023

Description

Ubuntu 18.04 packages OpenSSL 1.1.1 as 'libssl-dev' and other packages (namely libmysqlclient-dev -- needed for mysql2 gem) uninstall libssl1.0-dev and reinstall libssl-dev.

Issues Resolved

None

Check List

  • A summary of changes made is included in the CHANGELOG under ## Unreleased
  • New functionality includes testing.
  • New functionality has been documented in the README if applicable.

@SeanSith SeanSith requested a review from a team as a code owner May 10, 2023 18:22
@damacus damacus self-assigned this May 10, 2023
@damacus damacus added the Release: Minor Release to Chef Supermarket as a minor release when merged label May 10, 2023
damacus
damacus previously approved these changes May 10, 2023
@damacus
Copy link
Member

damacus commented May 10, 2023

I suspect 20 and 22,04 need fixing too. Care the take a gander at that?

@SeanSith
Copy link
Contributor Author

I know that Ubuntu 20.04 is fine. I'm having problems getting Test Kitchen and Dokken going on my M1. I'll see if I can spin up a 22.04 node somewhere.

@SeanSith
Copy link
Contributor Author

Ubuntu 22.04 is sane, too. I think we're good 👍

@damacus
Copy link
Member

damacus commented May 15, 2023

@SeanSith can you rebase for us, please?

Ubuntu 18.04 packages OpenSSL 1.1.1 as 'libssl-dev' and other packages
(namely libmysqlclient-dev -- needed for mysql2 gem) uninstall
libssl1.0-dev and reinstall libssl-dev.
Per conversation 2022-05-10 18:25 UTC in Chef Community Slack
@SeanSith
Copy link
Contributor Author

@damacus Rebased and checks are passing!

@damacus damacus enabled auto-merge (squash) May 16, 2023 07:59
@damacus damacus merged commit 1dd1330 into sous-chefs:main May 16, 2023
16 checks passed
@kitchen-porter
Copy link
Contributor

Released as: 2.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release: Minor Release to Chef Supermarket as a minor release when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants