Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom resource-ify #80

Merged
merged 23 commits into from
Apr 21, 2020
Merged

Custom resource-ify #80

merged 23 commits into from
Apr 21, 2020

Conversation

damacus
Copy link
Member

@damacus damacus commented Jan 23, 2019 •
edited
Loading

Description

  • Remove recipes
  • Add ruby_build_install resource
    It is now possible to specify jruby_deps and have jruby dependencies installed.
  • Add ruby_build_definition resource
  • Add unit testing

Issues Resolved

  • Attributes

Check List

This change is Reviewable

@kitchen-porter
Copy link
Contributor

1 Warning
⚠️ This is a big Pull Request.

Generated by 🚫 Danger

@damacus damacus force-pushed the refactor_simpler branch 2 times, most recently from e5871d0 to 04708d2 Compare January 23, 2019 14:45
tas50
tas50 reviewed Jan 23, 2019
View reviewed changes
resources/definition.rb Outdated Show resolved Hide resolved
tas50
tas50 reviewed Jan 23, 2019
View reviewed changes
resources/install.rb Outdated Show resolved Hide resolved
@damacus damacus force-pushed the refactor_simpler branch 3 times, most recently from 26dc38e to 41251cf Compare January 23, 2019 22:24
@damacus
Copy link
Member Author

damacus commented Jan 23, 2019

Surprise surprise, the old distros fail

@damacus
Copy link
Member Author

damacus commented Jan 23, 2019

And they only timeout, they're actually fine.

tas50
tas50 reviewed Jan 23, 2019
View reviewed changes
resources/definition.rb Outdated Show resolved Hide resolved
@xorima xorima added Feature Request Enhancement to existing functionality or new functionality Waiting on Contributor Awaiting on the person who raised this to update labels May 11, 2019
@tas50
Copy link
Contributor

tas50 commented Jan 26, 2020

@damacus Any chance you can rebase this one as well?

@damacus damacus requested a review from a team January 27, 2020 12:05
@xorima
Copy link
Contributor

xorima commented Feb 20, 2020

hey @damacus whats the status on this?

@damacus
Copy link
Member Author

damacus commented Feb 21, 2020

Markdown fixed. I think it's ready to ship.

@xorima
Copy link
Contributor

xorima commented Feb 21, 2020 •
edited
Loading

just an openjdk issue on debian10 mate,

Error executing action `install` on resource 'apt_package[openjdk-8-jdk, openjdk-8-jre-headless]'

can you get that one fixed and lgtm @damacus

@damacus
Copy link
Member Author

damacus commented Feb 21, 2020

This actually looks liek a problem with the Java cookbook. Debian 10 only supports OpenJDK11 now and the node default it 8.

I'll go and fix it there first and seeif this fixes things.

@damacus damacus mentioned this pull request Feb 21, 2020
Closed
@xorima
Copy link
Contributor

xorima commented Feb 21, 2020

As this is accurate to behaviour today I would be tempted to merge this if you are happy @damacus

@xorima
Copy link
Contributor

xorima commented Mar 11, 2020

@damacus could you sort out the merge work on this then I will just get it into master, master debian-10 is broken and that is not part of this PR ...

@damacus
Only test with JRuby for now
da0b7fe
@damacus
Remove flaky tests
aa1bae6 
This test regularly breaks locally and on CI so removing
@damacus
Update README
4a9393b
@damacus
Apply suggestions from code review
1af7b16 
Co-Authored-By: damacus <dan.webb@damacus.io>
@damacus
Fix new resoure
92c5647
@damacus
Fix markdown
2eb9ea6
@damacus damacus removed the Waiting on Contributor Awaiting on the person who raised this to update label Apr 20, 2020
@damacus damacus force-pushed the refactor_simpler branch 4 times, most recently from 495f51e to dde0327 Compare April 20, 2020 20:30
@damacus damacus merged commit 50116ca into master Apr 21, 2020
@damacus damacus deleted the refactor_simpler branch April 21, 2020 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tas50 tas50 tas50 left review comments

@SeanSith SeanSith SeanSith left review comments

Assignees

@damacus damacus

Labels
Feature Request Enhancement to existing functionality or new functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@damacus @kitchen-porter @tas50 @xorima @SeanSith