Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a line to only create a user if their password is specified #5

Closed
wants to merge 1 commit into from

Conversation

justincinmd
Copy link

I added this change so that samba users will only be created for some users, and not for every user in the users data bag.

@jesseadams
Copy link

👍 Very much this

@jtimberman
Copy link
Contributor

I'm sorry for the lack of response on this! I probably read the original notification on my phone and then forgot to followup.

GitHub indicates this can't be merged automatically, indicating there's a merge conflict.

Additionally, I think it may be better style to do something like this:

if users
  users.each do |u|
    next unless u["smbpasswd"]
    samba_user u["id"] do
      password u["smbpasswd"]
      action [:create, :enable]
    end
  end
end

CloCkWeRX added a commit to CloCkWeRX/samba that referenced this pull request May 15, 2014
@CloCkWeRX
Copy link
Contributor

Have done #18 which should resolve style, merge conflict issues.

@jtimberman jtimberman closed this May 16, 2014
@lock
Copy link

lock bot commented Jul 24, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants