Added a line to only create a user if their password is specified #5

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants

jcnnghm commented Mar 23, 2013

I added this change so that samba users will only be created for some users, and not for every user in the users data bag.

👍 Very much this

Member

jtimberman commented Feb 19, 2014

I'm sorry for the lack of response on this! I probably read the original notification on my phone and then forgot to followup.

GitHub indicates this can't be merged automatically, indicating there's a merge conflict.

Additionally, I think it may be better style to do something like this:

if users
  users.each do |u|
    next unless u["smbpasswd"]
    samba_user u["id"] do
      password u["smbpasswd"]
      action [:create, :enable]
    end
  end
end

CloCkWeRX added a commit to CloCkWeRX/samba that referenced this pull request May 15, 2014

Contributor

CloCkWeRX commented May 15, 2014

Have done #18 which should resolve style, merge conflict issues.

@jtimberman jtimberman closed this May 16, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment