-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[issue #119] Update fcontext to allow override of built-in types #120
base: main
Are you sure you want to change the base?
Conversation
…types Signed-off-by: Yansheng Wei <wei.yansheng@gmail.com>
See testing, for 3 of the instances, I am having issue with the driver. All others tested fine. |
Thanks for suggestion, I will re-run the test. Co-authored-by: Corey Hemminger <hemminger@hotmail.com>
Can you rebase or merge remote main into your current branch and then fix any failing tests. I just merged new test versions. |
Will do
…On Fri, May 3, 2024 at 1:56 PM Corey Hemminger ***@***.***> wrote:
Can you rebase or merge remote main into your current branch and then fix
any failing tests. I just merged new test versions.
—
Reply to this email directly, view it on GitHub
<#120 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHJK3CILXVICL2DJLC7BZATZAPMXDAVCNFSM6AAAAABGVZRYA2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJTGU4TKNZTG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
@Stromweld - Completed the testing. I had issues earlier which turned out to be the version of Chef Workstation I was using. I also had to make
|
@Stromweld - Any further actions on my side for the PR? Thanks. |
@Stromweld Anything I need to do before the PR can be merged? Thanks. |
Sorry for taking so long to get back to you. 1 last thing would be to update the .github/workflows/ci.yml to be similar to this one https://github.com/sous-chefs/php/blob/main/.github/workflows/ci.yml to fix the pipeline tests. |
f133d08
to
908a428
Compare
|
||
integration: | ||
needs: lint-unit | ||
runs-on: macos-10.15 | ||
runs-on: ubuntu-latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
under env: in the steps section need to add KITCHEN_LOCAL_YAML: kitchen.dokken.yml
@Stromweld - Do you have an example to pass the integration testing?
|
@Stromweld Can I get some help here? Sorry to bug you, I am looking for a working example to follow. Thanks. |
Description
Allow override of of the fcontext of system built-in file specs.
Issues Resolved
Issue #119
Check List
## Unreleased