['tomcat']['base_version'] is not getting overridden?

[melezhik]

chef client versions afftected:

11.16.4 , 12.0.3

cookbook version

tomcat@0.17.3

node ohai info (platform):

$ ohai  | grep platform
  "platform": "centos",
  "platform_version": "6.5",
  "platform_family": "rhel",

How to reproduce:

cat metadat/default.rb

name             'test'
version          '0.1.0'
depends          'tomcat'

cat recipes/default.rb

 node.override['tomcat']['base_version'] = 7
 include_recipe "tomcat"

chef-client -l info -r test

Starting Chef Client, version 12.0.3
[2015-03-05T12:21:13+00:00] INFO: *** Chef 12.0.3 ***
[2015-03-05T12:21:13+00:00] INFO: Chef-client pid: 12094
[2015-03-05T12:21:14+00:00] INFO: Setting the run_list to [#<Chef::RunList::RunListItem:0x00000002436cd0 @version=nil, @type=:recipe, @name="test">] from CLI options
[2015-03-05T12:21:14+00:00] INFO: Run List is [recipe[test]]
[2015-03-05T12:21:14+00:00] INFO: Run List expands to [test]
[2015-03-05T12:21:14+00:00] INFO: Starting Chef Run for ********
[2015-03-05T12:21:14+00:00] INFO: Running start handlers
[2015-03-05T12:21:14+00:00] INFO: Start handlers complete.
[2015-03-05T12:21:14+00:00] INFO: HTTP Request Returned 404 Object Not Found: 
resolving cookbooks for run list: ["test"]
[2015-03-05T12:21:14+00:00] INFO: Loading cookbooks [yum@3.5.2, yum-epel@0.6.0, chef-sugar@2.5.0, openssl@2.0.2, java@1.29.0, tomcat@0.17.3, test@0.1.0]
Synchronizing Cookbooks:
  - yum-epel
  - yum
  - openssl
  - chef-sugar
  - java
  - tomcat
  - test
Compiling Cookbooks...
Converging 4 resources
Recipe: yum-epel::default
  * yum_repository[epel] action create[2015-03-05T12:21:14+00:00] INFO: Processing yum_repository[epel] action create (yum-epel::default line 22)

    * template[/etc/yum.repos.d/epel.repo] action create[2015-03-05T12:21:14+00:00] INFO: Processing template[/etc/yum.repos.d/epel.repo] action create (/var/chef/cache/cookbooks/yum/providers/repository.rb line 39)
 (up to date)
    * execute[yum-makecache-epel] action nothing[2015-03-05T12:21:14+00:00] INFO: Processing execute[yum-makecache-epel] action nothing (/var/chef/cache/cookbooks/yum/providers/repository.rb line 55)
 (skipped due to action :nothing)
    * ruby_block[yum-cache-reload-epel] action nothing[2015-03-05T12:21:14+00:00] INFO: Processing ruby_block[yum-cache-reload-epel] action nothing (/var/chef/cache/cookbooks/yum/providers/repository.rb line 62)
 (skipped due to action :nothing)
     (up to date)
Recipe: tomcat::default
  * yum_package[tomcat6] action install

I just wonder why tomcat6 package gets installed? I expect according to the following code , i should be `tomcat' package ?

cat tomcat/attributes/default.rb :

default['tomcat']['base_version'] = 6
...
...
...
...

case node['platform_family']

when 'rhel', 'fedora'
  suffix = node['tomcat']['base_version'].to_i < 7 ? node['tomcat']['base_version'] : ""
  ....
  default['tomcat']['packages'] = ["tomcat#{suffix}"]

[marc-]

This cookbook needs refactoring. Please see #89, #102 and especially this comment.

[melezhik]

This cookbook needs refactoring

Thank you. When you are going to fix this?

[marc-]

You better ask @someara or @jtimberman .

[tas50]

First off I'm very sorry that it's taken so long to get back to you on this issue. For a significant period of time there was no active Chef Software Inc. maintainer for this repository and things languished. We're now actively maintaining this cookbook again, and as part of that I've rewritten the cookbook with new custom resources for installing Tomcat from Apache Org sources. This will ship in an upcoming 2.0 release and then we'll remove the existing recipes and providers in a future 3.X release. With those new providers I believe the need for this change goes away so I'm going to close this out. I encourage you to give the new providers a try and let me know if we can tackle more Tomcat management without the attributes bloat the current code suffers from. They're on the master branch and once the documentation and testing improves a bit they'll be released as a 2.0 cookbook.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.