Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to add config watching and test coverage #27

Merged
merged 20 commits into from
Sep 28, 2017
Merged

Conversation

dcalhoun
Copy link
Collaborator

@dcalhoun dcalhoun commented Sep 16, 2017

Includes a significant refactor to accomplish the following.

  • Improve test coverage.
  • Add config watching (i.e. remove need to restart Hyper after updating hyper.js config).
  • Utilize Hyper’s set of windows rather than managing a duplicate set within the plugin.
  • Change default setting for hideOnBlur as it was confusing users.
  • Properly remove event handlers during plugin uninstallation.
  • Add StandardJS linter to avoid syntax errors.

Jest Coverage Report

------------|----------|----------|----------|----------|----------------|
File        |  % Stmts | % Branch |  % Funcs |  % Lines |Uncovered Lines |
------------|----------|----------|----------|----------|----------------|
All files   |    96.43 |    86.36 |    94.12 |    97.96 |                |
 app.js     |    94.44 |      100 |       80 |      100 |                |
 dispose.js |      100 |      100 |      100 |      100 |                |
 toggle.js  |      100 |      100 |      100 |      100 |                |
 windows.js |    96.55 |    81.25 |      100 |    96.15 |             49 |
------------|----------|----------|----------|----------|----------------|

@dcalhoun dcalhoun merged commit 0393ca1 into master Sep 28, 2017
@dcalhoun dcalhoun deleted the add-test-coverage branch September 28, 2017 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant