New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hotkey not being set from config #55

Closed

robbplo wants to merge 1 commit into soutar:master from robbplo:master

robbplo commented Jan 18, 2020 •

edited

Loading

I found that the hotkey was always being set from the default value, here's a little PR :)


          Fix hotkey not being set from config

1d8ccc8

Collaborator

dcalhoun commented Jan 18, 2020

The third parameter of registerShortcut is a default hotkey, not the hotkey of choice itself. The hotkey of choice is taken from the config key on the app object.

I do not believe this is a valid change that is required. If I a mistaken, please help me understand what issue you are experiencing.

dcalhoun closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment