Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a missing attr_reader in the example code #448

Merged
merged 1 commit into from Nov 14, 2021
Merged

Add a missing attr_reader in the example code #448

merged 1 commit into from Nov 14, 2021

Conversation

kymmt90
Copy link
Contributor

@kymmt90 kymmt90 commented Nov 9, 2021

The Phone class should have attr_reader :country, :number if Phone#== uses other.country and other.number.

soutaro
soutaro approved these changes Nov 14, 2021
View reviewed changes
Copy link
Owner

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! 👏

@soutaro soutaro merged commit 29437b7 into soutaro:master Nov 14, 2021
@kymmt90 kymmt90 deleted the patch-1 branch November 14, 2021 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soutaro soutaro soutaro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kymmt90 @soutaro