Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support type narrowing by Module#< #877

Merged
merged 2 commits into from
Oct 27, 2023
Merged

Conversation

tk0miya
Copy link
Contributor

@tk0miya tk0miya commented Jul 19, 2023

Module#< and Module#<= means the argument is the ancestor of the receiver. Thefore this allows to Steep to do narrowing the type of the receiver to the given argument.

@soutaro soutaro added this to the Steep 1.6 milestone Jul 20, 2023
@soutaro soutaro changed the title Support type narrowing by Module#< Support type narrowing by Module#< Jul 20, 2023
tk0miya and others added 2 commits October 27, 2023 11:42
Module#< and Module#<= means the argument is the ancestor of the
receiver.  Thefore this allows to Steep to do narrowing the type of the
receiver to the given argument.
Copy link
Owner

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the pull request! 🎉 And I'm sorry for the big delay... 🙇‍♂️

@soutaro soutaro added the area/core Issues related to the type checker core label Oct 27, 2023
@soutaro soutaro merged commit d2a9568 into soutaro:master Oct 27, 2023
15 checks passed
@soutaro soutaro added the Released The PR is already included in a published release label Oct 27, 2023
@tk0miya tk0miya deleted the arg_is_ancestor branch October 28, 2023 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core Issues related to the type checker core Released The PR is already included in a published release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants