Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better completion with module alias and use directives #923

Merged
merged 3 commits into from
Oct 11, 2023

Conversation

soutaro
Copy link
Owner

@soutaro soutaro commented Oct 3, 2023

Type name completion didn't work with module/class aliases or use directives

use Foo as Foo2

module Foo
  module Bar
  end
end

module Foo1 = Foo

type t1 = Foo1::B    # <= Completion didn't work because `Foo1` is a module alias
type t2 = Foo2::B   # <= Completion didn't work because `Foo2` is a `use` type name

This also fixes a completion triggered with an absolute type name -- ::Foo.

@soutaro soutaro added this to the Steep 1.6 milestone Oct 3, 2023
@soutaro soutaro added the bug label Oct 3, 2023
@soutaro soutaro merged commit b760c45 into master Oct 11, 2023
20 checks passed
@soutaro soutaro deleted the fix-completion branch October 11, 2023 13:47
@soutaro soutaro added the Released The PR is already included in a published release label Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Released The PR is already included in a published release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant