Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fewer UnresolvedOverloading #941

Merged
merged 3 commits into from
Oct 26, 2023
Merged

Fewer UnresolvedOverloading #941

merged 3 commits into from
Oct 26, 2023

Conversation

soutaro
Copy link
Owner

@soutaro soutaro commented Oct 26, 2023

UnresolvedOverloading error is not very helpful. The developers should read the error message carefully, and uncover what is causing type errors theirselves.

This PR is to report fewer UnresolvedOverloading by filtering arity type errors first.

If a required block is not given, we can guess it's not the intended method type overload. Same for other arguments.

Working for #937

@soutaro soutaro added this to the Steep 1.6 milestone Oct 26, 2023
@soutaro soutaro linked an issue Oct 26, 2023 that may be closed by this pull request
@soutaro soutaro added the area/core Issues related to the type checker core label Oct 26, 2023
@soutaro soutaro merged commit d5ac390 into master Oct 26, 2023
15 checks passed
@soutaro soutaro deleted the unresolved-overloading branch October 26, 2023 03:25
@soutaro soutaro added the Released The PR is already included in a published release label Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core Issues related to the type checker core Released The PR is already included in a published release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better method call error reporting
1 participant