Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let label be whole method type in SignatureHelp #942

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Let label be whole method type in SignatureHelp #942

merged 1 commit into from
Oct 26, 2023

Conversation

soutaro
Copy link
Owner

@soutaro soutaro commented Oct 26, 2023

スクリーンショット 2023-10-26 17 19 17

It was displaying the type of parameters of the method type, but it was confusing, when return types or block types are different.

This PR displays the whole method type in the popup.

@soutaro soutaro added this to the Steep 1.6 milestone Oct 26, 2023
@soutaro soutaro added the area/lsp Issues related to language server label Oct 26, 2023
@soutaro soutaro merged commit 66a2f95 into master Oct 26, 2023
17 checks passed
@soutaro soutaro deleted the signature-help branch October 26, 2023 08:48
@soutaro soutaro added the Released The PR is already included in a published release label Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/lsp Issues related to language server Released The PR is already included in a published release
Projects
None yet
Milestone
Steep 1.6
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@soutaro