Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let goto definition work from UnresolvedOverloading error calls #943

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Let goto definition work from UnresolvedOverloading error calls #943

merged 1 commit into from
Oct 27, 2023

Conversation

soutaro
Copy link
Owner

@soutaro soutaro commented Oct 27, 2023

This fixes a bug that goto definition from method calls with errors don't work sometimes.

スクリーンショット 2023-10-27 10 10 05

This is caused because MethodCall::Error instantiation doesn't have method_decls if UnresolvedOverloading is to be reported.

@soutaro soutaro added area/core Issues related to the type checker core area/lsp Issues related to language server labels Oct 27, 2023
@soutaro soutaro added this to the Steep 1.6 milestone Oct 27, 2023
@soutaro soutaro merged commit ebb276f into master Oct 27, 2023
17 checks passed
@soutaro soutaro deleted the goto-from-error branch October 27, 2023 01:57
@soutaro soutaro added the Released The PR is already included in a published release label Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/core Issues related to the type checker core area/lsp Issues related to language server Released The PR is already included in a published release
Projects
None yet
Milestone
Steep 1.6
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@soutaro