Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assign types on method calls in mlhs node #951

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Assign types on method calls in mlhs node #951

merged 1 commit into from
Oct 31, 2023

Conversation

soutaro
Copy link
Owner

@soutaro soutaro commented Oct 31, 2023

It caused an error during completion:

[Steep 1.6.0.pre.1] [interaction:interaction] [background] Unexpected error: #<NoMethodError: undefined method `class?' for nil:NilClass>
[Steep 1.6.0.pre.1] [interaction:interaction] [background]   .../ruby/gems/3.2.0/gems/rbs-3.2.2/lib/rbs/environment.rb:337:in `normalize_module_name?'
[Steep 1.6.0.pre.1] [interaction:interaction] [background]   .../ruby/gems/3.2.0/gems/rbs-3.2.2/lib/rbs/environment.rb:333:in `normalize_module_name'
[Steep 1.6.0.pre.1] [interaction:interaction] [background]   .../ruby/gems/3.2.0/gems/rbs-3.2.2/lib/rbs/resolver/constant_resolver.rb:113:in `children'
[Steep 1.6.0.pre.1] [interaction:interaction] [background]   .../ruby/gems/3.2.0/gems/steep-1.6.0.pre.1/lib/steep/type_inference/constant_env.rb:38:in `children'
[Steep 1.6.0.pre.1] [interaction:interaction] [background]   .../ruby/gems/3.2.0/gems/steep-1.6.0.pre.1/lib/steep/services/completion_provider.rb:667:in `constant_items_for_context'
[Steep 1.6.0.pre.1] [interaction:interaction] [background]   .../ruby/gems/3.2.0/gems/steep-1.6.0.pre.1/lib/steep/services/completion_provider.rb:502:in `items_for_colon2'
[Steep 1.6.0.pre.1] [interaction:interaction] [background]   .../ruby/gems/3.2.0/gems/steep-1.6.0.pre.1/lib/steep/services/completion_provider.rb:403:in `items_for_trigger'
[Steep 1.6.0.pre.1] [interaction:interaction] [background]   .../ruby/gems/3.2.0/gems/steep-1.6.0.pre.1/lib/steep/services/completion_provider.rb:242:in `block in run'
[Steep 1.6.0.pre.1] [interaction:interaction] [background]   .../ruby/gems/3.2.0/gems/steep-1.6.0.pre.1/lib/steep.rb:178:in `measure'
[Steep 1.6.0.pre.1] [interaction:interaction] [background]   .../ruby/gems/3.2.0/gems/steep-1.6.0.pre.1/lib/steep/services/completion_provider.rb:241:in `run'
[Steep 1.6.0.pre.1] [interaction:interaction] [background]   .../ruby/gems/3.2.0/gems/steep-1.6.0.pre.1/lib/steep/server/interaction_worker.rb:123:in `block (2 levels) in process_completion'
[Steep 1.6.0.pre.1] [interaction:interaction] [background]   .../ruby/gems/3.2.0/gems/steep-1.6.0.pre.1/lib/steep.rb:178:in `measure'
[Steep 1.6.0.pre.1] [interaction:interaction] [background]   .../ruby/gems/3.2.0/gems/steep-1.6.0.pre.1/lib/steep/server/interaction_worker.rb:113:in `block in process_completion'
[Steep 1.6.0.pre.1] [interaction:interaction] [background]   .../ruby/gems/3.2.0/gems/activesupport-7.1.1/lib/active_support/tagged_logging.rb:135:in `block in tagged'
[Steep 1.6.0.pre.1] [interaction:interaction] [background]   .../ruby/gems/3.2.0/gems/activesupport-7.1.1/lib/active_support/tagged_logging.rb:39:in `tagged'
[Steep 1.6.0.pre.1] [interaction:interaction] [background]   .../ruby/gems/3.2.0/gems/activesupport-7.1.1/lib/active_support/tagged_logging.rb:135:in `tagged'
[Steep 1.6.0.pre.1] [interaction:interaction] [background]   .../ruby/gems/3.2.0/gems/steep-1.6.0.pre.1/lib/steep/server/interaction_worker.rb:112:in `process_completion'
[Steep 1.6.0.pre.1] [interaction:interaction] [background]   .../ruby/gems/3.2.0/gems/steep-1.6.0.pre.1/lib/steep/server/interaction_worker.rb:38:in `block in handle_job'
[Steep 1.6.0.pre.1] [interaction:interaction] [background]   .../ruby/gems/3.2.0/gems/activesupport-7.1.1/lib/active_support/tagged_logging.rb:135:in `block in tagged'
[Steep 1.6.0.pre.1] [interaction:interaction] [background]   .../ruby/gems/3.2.0/gems/activesupport-7.1.1/lib/active_support/tagged_logging.rb:39:in `tagged'
[Steep 1.6.0.pre.1] [interaction:interaction] [background]   .../ruby/gems/3.2.0/gems/activesupport-7.1.1/lib/active_support/tagged_logging.rb:135:in `tagged'
[Steep 1.6.0.pre.1] [interaction:interaction] [background]   .../ruby/gems/3.2.0/gems/steep-1.6.0.pre.1/lib/steep/server/interaction_worker.rb:24:in `handle_job'
[Steep 1.6.0.pre.1] [interaction:interaction] [background]   .../ruby/gems/3.2.0/gems/steep-1.6.0.pre.1/lib/steep/server/base_worker.rb:56:in `block (2 levels) in run'
[Steep 1.6.0.pre.1] [interaction:interaction] [background]   .../ruby/gems/3.2.0/gems/activesupport-7.1.1/lib/active_support/tagged_logging.rb:135:in `block in tagged'
[Steep 1.6.0.pre.1] [interaction:interaction] [background]   .../ruby/gems/3.2.0/gems/activesupport-7.1.1/lib/active_support/tagged_logging.rb:39:in `tagged'
[Steep 1.6.0.pre.1] [interaction:interaction] [background]   .../ruby/gems/3.2.0/gems/activesupport-7.1.1/lib/active_support/tagged_logging.rb:135:in `tagged'
[Steep 1.6.0.pre.1] [interaction:interaction] [background]   .../ruby/gems/3.2.0/gems/steep-1.6.0.pre.1/lib/steep/server/base_worker.rb:46:in `block in run'

@soutaro soutaro added the area/core Issues related to the type checker core label Oct 31, 2023
@soutaro soutaro added this to the Steep 1.6 milestone Oct 31, 2023
@soutaro soutaro merged commit cc38703 into master Oct 31, 2023
17 checks passed
@soutaro soutaro deleted the nil-error branch October 31, 2023 03:36
@soutaro soutaro added the Released The PR is already included in a published release label Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/core Issues related to the type checker core Released The PR is already included in a published release
Projects
None yet
Milestone
Steep 1.6
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@soutaro