-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider renaming to avoid conflict with jsok/vault? #1
Comments
I'm not opposed to re-naming the module, but I may end up just submitting the useful components as part of this existing module: https://github.com/voxpupuli/puppet-vault_lookup I imagine this would be acceptable, maybe preferable? |
Either would be good :) |
There is now a vault_secrets branch you can use for testing |
Thanks for this! I got a PoC semi-working this evening using the branch. Still got some things to work out (like a |
Renewal of the certificate should be driven by the "vault_cert" fact. Verify this fact is being reported correctly. If there's an issue I'd appreciate the feedback to fix the problem. |
To avoid taking this issue off-topic, I've moved this discussion to #2. I'm happy that this branch is working as expected 👍 |
I've posted the module to Puppet Forge with the "vault_secrets" name with a deprecation notice for the original. |
Hi,
First up, thanks for publishing this module, it looks like it will be very useful!
Due to puppet modules needing to be uniquely named within a single puppet environment, would you consider renaming this one so that it can be used in conjunction with https://forge.puppet.com/modules/jsok/vault, which is used to deploy vault itself? Currently, because both modules are named the same, puppet cannot be used to both deploy the vault service, and also consume secrets from it to manage other services using these two modules together.
Perhaps something like
vault_functions
, orvault_secrets
as an alternative?Thanks,
Ben
The text was updated successfully, but these errors were encountered: