Consider renaming to avoid conflict with jsok/vault?

[optiz0r]

Hi,

First up, thanks for publishing this module, it looks like it will be very useful!

Due to puppet modules needing to be uniquely named within a single puppet environment, would you consider renaming this one so that it can be used in conjunction with https://forge.puppet.com/modules/jsok/vault, which is used to deploy vault itself? Currently, because both modules are named the same, puppet cannot be used to both deploy the vault service, and also consume secrets from it to manage other services using these two modules together.

Perhaps something like vault_functions, or vault_secrets as an alternative?

Thanks,
Ben

[southalc]

I'm not opposed to re-naming the module, but I may end up just submitting the useful components as part of this existing module: ​https://github.com/voxpupuli/puppet-vault_lookup

I imagine this would be acceptable, maybe preferable?

[optiz0r]

Either would be good :)

[southalc]

There is now a vault_secrets branch you can use for testing

[optiz0r]

Thanks for this! I got a PoC semi-working this evening using the branch. Still got some things to work out (like a vault_cert getting replaced on every puppet run), but so far so good :)

[southalc]

Renewal of the certificate should be driven by the "vault_cert" fact. Verify this fact is being reported correctly. If there's an issue I'd appreciate the feedback to fix the problem.

[optiz0r]

Verify this fact is being reported correctly. If there's an issue I'd appreciate the feedback to fix the problem.

To avoid taking this issue off-topic, I've moved this discussion to #2. I'm happy that this branch is working as expected 👍

[southalc]

I've posted the module to Puppet Forge with the "vault_secrets" name with a deprecation notice for the original.