Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor code #74

Merged
merged 4 commits into from
Apr 27, 2023
Merged

Refactor code #74

merged 4 commits into from
Apr 27, 2023

Conversation

souvikinator
Copy link
Owner

@souvikinator souvikinator commented Apr 21, 2023 •
edited

b35e168 (#74)

  • Fix column and column_list handler

more to add...

@souvikinator souvikinator added the enhancement New feature or request label Apr 21, 2023
@souvikinator souvikinator linked an issue Apr 21, 2023 that may be closed by this pull request
Improving the complexity and flow of the package #73
Closed
@souvikinator
Copy link
Owner Author

23c44db (#74)

  • Lower abstraction methods (like blockToMarkdown) must not call higher abstraction methods (like toMarkdownString)

Why?:

  • blockToMarkdown converts a single block to a markdown string
  • toMarkdownString processes & combines all the MdBlock[] content.

Both work at different abstraction levels and should only do the work they are responsible for. (Idk if this is right but
sounds good to me 😅)

  • Move toggle handler from blockToMarkdown to toMarkdownString to maintain the output format of blocksToMarkdown

@souvikinator souvikinator marked this pull request as ready for review April 27, 2023 07:35
@souvikinator souvikinator merged commit 1572f60 into master Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improving the complexity and flow of the package
1 participant
@souvikinator