Update CustomTransformer type #94
Conversation
src/types/index.ts
Outdated
| @@ -143,4 +143,4 @@ export type CalloutIcon = | |||
|
|
|||
| export type CustomTransformer = ( | |||
| block: ListBlockChildrenResponseResult | |||
| ) => string | Promise<string>; | |||
| ) => string | false | Promise<string | boolean>; | |||
There was a problem hiding this comment.
It looks like that Promise<string | false> won't work because TS infers its type as Promise<boolean> when I try to only return false inside async callback.
Example:
n2m.setCustomTransformer("embed", async (block) => {
return false;
});Type 'Promise' is not assignable to type 'string | Promise<string | false>'
There was a problem hiding this comment.
That is because over here
notion-to-md/src/notion-to-md.ts
Line 270 in 8c15e94
if the value is false then it's inferring type as
string|true (since boolean can be true as well as false)
A simple fix is to just check the type of the returned value as string in the if statement in the above lines instead of checking true/false.
|
Thank you for your contribution. I made necessary changes and merged the PR. This fix should be live in the upcoming release along with other bug fixes |
Thank you! |
Update
CustomTransformertype to support thefalsereturn. #93Before:
