Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusion over params capture #4

Closed
bemurphy opened this issue Mar 16, 2011 · 3 comments
Closed

Confusion over params capture #4

bemurphy opened this issue Mar 16, 2011 · 3 comments

Comments

@bemurphy
Copy link
Contributor

I was asking in #cuba.rb on this. The channel consensus seems to be that on param() matching should match blank (non-nil) param values. That is how the code behaves now.

However, the README, example, and comments seem to imply it's for checking the presence of a real, non-blank value. I'm confused which it is.

If the behavior is wrong, I can submit a pull request with tests. Thanks.

@soveran
Copy link
Owner

soveran commented Apr 6, 2011

Hey, Cuba changed quit a bit recently. I just updated the README in order to better document how captures work, can you check if it makes sense now? https://github.com/soveran/cuba

@bemurphy
Copy link
Contributor Author

bemurphy commented Apr 6, 2011

@soveran Yeah, it's good. I meant to close this, I'm actually the guy who was talking to you on #freenode about it. Thanks.

@bemurphy bemurphy closed this as completed Apr 6, 2011
@soveran
Copy link
Owner

soveran commented Apr 6, 2011

@bemurphy Oh, excellent then. I remember the conversation now :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants