indicates the thought patterns of someone with an ActiveRecord backgr… #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TheNotary Thanks! This is a great idea, I will work one this on Monday and give you feedback. It looks very good, I think we will be able to merge it next week. |
|
|
||
| class Loadout < Ohm::Model | ||
| attribute :head_id | ||
| reference :head, :Item |
There was a problem hiding this comment.
The reference macro already defines the head_id attribute, so all the attribute :*_id lines can be removed.
|
Thanks for the feedback, and wow, good to know about deps and gs, I hadn't heard of this approach! I'm a bit short on freetime at the moment, but I'll flesh out that second test... and I'll do a 'populate_db' method for populating items so they can be |
scalp42
reviewed
Sep 22, 2016
| reference :equipment, :Loadout | ||
| end | ||
|
|
||
| # We define both a `Video` and `Audio` model, with a `list` of *comments*. |
There was a problem hiding this comment.
I think it's from a different example this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ound
First thanks for working on this! Interacting directly with Redis does not seem workable for complex projects. Could I possibly get some feedback on this PR, rework the commit and then get it merged into the repo to help others who might have wanted to know similar things?