Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mail_virtual_domains config reading in opendkim #618

Merged
merged 1 commit into from Nov 17, 2016

Conversation

nfedyashev
Copy link
Contributor

without this change it fails on ansible(2.2.0.0) with the following message:

TASK [mailserver : Generate OpenDKIM keys] *************************************
fatal: [sovereign.host]: FAILED! => {"failed": true, "msg": "the field 'args' has an invalid value, which appears to include a variable that is undefined. The error was: 'unicode object' has no attribute 'name'\n\nThe error appears to have been in '/Users/nfedyashev/Projects/sovereign/roles/mailserver/tasks/opendkim.yml': line 19, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: Generate OpenDKIM keys\n  ^ here\n"}

without this change it fails on ansible(2.2.0.0) with the following message:

    TASK [mailserver : Generate OpenDKIM keys] *************************************
    fatal: [sovereign.host]: FAILED! => {"failed": true, "msg": "the field 'args' has an invalid value, which appears to include a variable that is undefined. The error was: 'unicode object' has no attribute 'name'\n\nThe error appears to have been in '/Users/nfedyashev/Projects/sovereign/roles/mailserver/tasks/opendkim.yml': line 19, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: Generate OpenDKIM keys\n  ^ here\n"}
@nfedyashev
Copy link
Contributor Author

I'm not an expert in ansible but that update allowed me to continue running this playbook

@jplock
Copy link
Contributor

jplock commented Nov 17, 2016

There are a few other places in the roles where we need to fix this too. Thanks!

@jplock jplock merged commit ba3cbb6 into sovereign:master Nov 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants