Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate the broker's extensions #921

Merged
merged 50 commits into from
May 27, 2024
Merged

Integrate the broker's extensions #921

merged 50 commits into from
May 27, 2024

Conversation

ununhexium
Copy link
Collaborator

@ununhexium ununhexium commented May 3, 2024 •
edited

Partially closes https://github.com/sovity/PMO-Software/issues/972

Checklist

Edit tasklist title
Beta Give feedback Tasklist Checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. The PR title is short and expressive.
    Options
  2. I have updated the CHANGELOG.md. See changelog_update.md for more information.
    Options
  3. I have updated the Deployment Migration Notes Section in the CHANGELOG.md for any configuration / external API changes.
    Options
  4. I have performed a self-review
    Options

@ununhexium ununhexium changed the title Integrate the broker's source with gradle Integrate the broker's extensions with gradle May 3, 2024
@ununhexium ununhexium mentioned this pull request May 3, 2024
Closed
richardtreier
richardtreier requested changes May 6, 2024
View reviewed changes
Copy link
Collaborator

@richardtreier richardtreier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job on making the gradle builds more type-safe

extensions/broker-server-api/client/build.gradle.kts Outdated Show resolved Hide resolved
extensions/broker-server-api/client/build.gradle.kts Outdated Show resolved Hide resolved
extensions/broker-server-postgres-flyway-jooq/build.gradle.kts Outdated Show resolved Hide resolved
@ununhexium ununhexium force-pushed the 972-group-edc-ce-ui-broker-part3.1 branch from 9b5440b to 8c09b2c Compare May 6, 2024 12:11
ununhexium
ununhexium commented May 8, 2024
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
launchers/Dockerfile Outdated Show resolved Hide resolved
@ununhexium ununhexium force-pushed the 972-group-edc-ce-ui-broker-part3.1 branch from 6aac059 to 5eba542 Compare May 13, 2024 08:32
@ununhexium ununhexium force-pushed the 972-group-edc-ce-ui-broker-part3.1 branch from 846347f to f634082 Compare May 17, 2024 13:06
richardtreier
richardtreier requested changes May 21, 2024
View reviewed changes
.github/workflows/release_docs_zip.yml Outdated Show resolved Hide resolved
docs/deployment-guide/goals/broker-local-demo/README.md Outdated Show resolved Hide resolved
docs/deployment-guide/goals/production/4.2.0/README.md Outdated Show resolved Hide resolved
extensions/broker-server/README.md Outdated Show resolved Hide resolved
utils/versions/build.gradle.kts Outdated Show resolved Hide resolved
tmberthold
tmberthold reviewed May 23, 2024
View reviewed changes
Copy link
Member

@tmberthold tmberthold left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, wrong conclusion on my part, the long CI runtime might have been caused by the problems of GitHub itself two days ago. https://github.com/sovity/edc-extensions/actions/workflows/ci.yml?query=branch%3A972-group-edc-ce-ui-broker-part3.1

richardtreier
richardtreier approved these changes May 27, 2024
View reviewed changes
Copy link
Collaborator

@richardtreier richardtreier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richardtreier richardtreier merged commit f6fe5d0 into integration/broker-merge May 27, 2024
10 checks passed
@richardtreier richardtreier deleted the 972-group-edc-ce-ui-broker-part3.1 branch May 27, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmberthold tmberthold tmberthold left review comments

@richardtreier richardtreier richardtreier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ununhexium @richardtreier @tmberthold