fix: allow method parameterization to be skipped

sovity · Apr 10, 2024 · 434d591 · 434d591
1 parent 53bf959
commit 434d591
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -23,6 +23,7 @@ the detailed section referring to by linking pull requests or issues.
 - Fixed an asset select issue resulting from a bad compare function
 - Asset: Fix double encoding of query params by disallowing '&' and '=' chars in
   form field and sending them unencoded
+- Fixed Method Parameterization always showing "GET", added unselected option.
 
 #### Deployment Migration Notes
 

diff --git a/src/app/core/services/http-params-mapper.service.ts b/src/app/core/services/http-params-mapper.service.ts
@@ -48,7 +48,7 @@ export class HttpRequestParamsMapper {
       asset.httpDatasourceHintsProxyBody;
 
     return removeNullValues({
-      [DataAddressProperty.method]: proxyMethod ? method : null,
+      [DataAddressProperty.method]: proxyMethod && method ? method : null,
       [DataAddressProperty.pathSegments]: proxyPath ? pathSegments : null,
       [DataAddressProperty.queryParams]: proxyQueryParams ? queryParams : null,
       [DataAddressProperty.body]: proxyBody ? body : null,

diff --git a/...eement-page/contract-agreement-transfer-dialog/contract-agreement-transfer-dialog-form.ts b/...eement-page/contract-agreement-transfer-dialog/contract-agreement-transfer-dialog-form.ts
@@ -58,7 +58,7 @@ export class ContractAgreementTransferDialogForm {
         showAllHttpParameterizationFields: [false],
 
         httpProxiedPath: [''],
-        httpProxiedMethod: ['GET'],
+        httpProxiedMethod: [''],
         httpProxiedQueryParams: this.formBuilder.array(
           new Array<FormGroup<HttpDatasourceQueryParamFormModel>>(),
         ),

diff --git a/...page/contract-agreement-transfer-dialog/contract-agreement-transfer-dialog.component.html b/...page/contract-agreement-transfer-dialog/contract-agreement-transfer-dialog.component.html
@@ -234,7 +234,8 @@ <h1 mat-dialog-title>Initiate Transfer</h1>
               *ngIf="form.all.controls.httpProxiedMethod; let ctrl"
               [ngClass]="{'w-1/3': proxyPath}">
               <mat-label>Custom Method</mat-label>
-              <mat-select [formControl]="ctrl">
+              <mat-select placeholder="Custom Method" [formControl]="ctrl">
+                <mat-option></mat-option>
                 <mat-option
                   *ngFor="let method of dataSourceMethods"
                   [value]="method"

diff --git a/...t-page/contract-agreement-transfer-dialog/contract-agreement-transfer-dialog.component.ts b/...t-page/contract-agreement-transfer-dialog/contract-agreement-transfer-dialog.component.ts
@@ -35,28 +35,28 @@ export class ContractAgreementTransferDialogComponent implements OnDestroy {
   get proxyMethod(): boolean {
     return (
       this.showAllHttpParameterizationFields ||
-      this.data.asset.httpDatasourceHintsProxyMethod == true
+      this.data.asset.httpDatasourceHintsProxyMethod === true
     );
   }
 
   get proxyPath(): boolean {
     return (
       this.showAllHttpParameterizationFields ||
-      this.data.asset.httpDatasourceHintsProxyPath == true
+      this.data.asset.httpDatasourceHintsProxyPath === true
     );
   }
 
   get proxyQueryParams(): boolean {
     return (
       this.showAllHttpParameterizationFields ||
-      this.data.asset.httpDatasourceHintsProxyQueryParams == true
+      this.data.asset.httpDatasourceHintsProxyQueryParams === true
     );
   }
 
   get proxyBody(): boolean {
     return (
       this.showAllHttpParameterizationFields ||
-      this.data.asset.httpDatasourceHintsProxyBody == true
+      this.data.asset.httpDatasourceHintsProxyBody === true
     );
   }