Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat contract agreement page rework #240

Merged
merged 3 commits into from
Apr 26, 2023
Merged

feat contract agreement page rework #240

merged 3 commits into from
Apr 26, 2023

Conversation

richardtreier
Copy link
Collaborator

@richardtreier richardtreier commented Apr 25, 2023 •
edited
Loading

closes #230

@richardtreier richardtreier linked an issue Apr 25, 2023 that may be closed by this pull request
Migrate Contract Agreement Page to API Wrapper #230
Closed
6 tasks
@richardtreier richardtreier force-pushed the 230-migrate-contract-agreement-page-to-api-wrapper branch 6 times, most recently from 97938c2 to 8dfafa8 Compare April 25, 2023 14:13
@richardtreier richardtreier enabled auto-merge (squash) April 25, 2023 14:13
@richardtreier richardtreier force-pushed the 230-migrate-contract-agreement-page-to-api-wrapper branch from 8dfafa8 to 43eaed6 Compare April 25, 2023 14:23
@richardtreier richardtreier force-pushed the 230-migrate-contract-agreement-page-to-api-wrapper branch from 43eaed6 to 72433c8 Compare April 25, 2023 14:30
Krieke
Krieke reviewed Apr 26, 2023
View reviewed changes
Copy link

@Krieke Krieke left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • What is the purpose of the edc-demo module? There doesn't seem to be a README.md describing it
  • What is the purpose of the edc-dmgmt-client module? No description can be found in the README.md
  • No README updates found related to this new feature.

src/modules/app/config/edc-api.service.ts Outdated Show resolved Hide resolved
src/modules/edc-demo/components/ago/ago.component.ts Show resolved Hide resolved
@richardtreier richardtreier merged commit 9dcdea0 into main Apr 26, 2023
@richardtreier richardtreier deleted the 230-migrate-contract-agreement-page-to-api-wrapper branch April 26, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmberthold tmberthold tmberthold approved these changes

@Krieke Krieke Awaiting requested review from Krieke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate Contract Agreement Page to API Wrapper
3 participants
@richardtreier @Krieke @tmberthold