Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented replace classes in concat statement #17

Merged
merged 2 commits into from
Apr 6, 2023
Merged

Implemented replace classes in concat statement #17

merged 2 commits into from
Apr 6, 2023

Conversation

candunaj
Copy link
Contributor

@candunaj candunaj commented Apr 6, 2023

This PR adds support for replacing classes inside concat statement as shown below.

The following

<div class='some-class {{this.someVariable}}'></div>

will be changed to

<div class='some-class_generated {{this.someVariable}}'></div>

@candunaj candunaj force-pushed the replace-concat branch 2 times, most recently from c610941 to c2a0567 Compare April 6, 2023 12:12
@candunaj candunaj marked this pull request as ready for review April 6, 2023 12:12
@candunaj candunaj requested a review from mansona April 6, 2023 12:15
mansona
mansona approved these changes Apr 6, 2023
View reviewed changes
Copy link
Contributor

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🎉

@mansona mansona merged commit fc6a6d2 into main Apr 6, 2023
@mansona mansona deleted the replace-concat branch April 6, 2023 13:04
@mansona mansona mentioned this pull request Apr 11, 2023
Closed
@mansona mansona added the bug Something isn't working label Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mansona mansona mansona approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@candunaj @mansona