Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented scoped-class helper for classic app #37

Merged
merged 3 commits into from
May 29, 2023

Conversation

candunaj
Copy link
Contributor

@candunaj candunaj commented May 29, 2023

scoped-class helper was implemented as a babel plugin for v2 addons. To simplify the solution and support classic apps and v2 addons this functionality was moved to rewriteHbs function where it belongs. This function is used in unplugin plugin for v2 addons and in babel plugin already implemented for classic apps.

An example of scoped-class helper

The following

<SomeComponent @class={{scoped-class 'some-class'}} />

will be transformed

<SomeComponent @class='some-class_e2333545' />

@candunaj candunaj marked this pull request as ready for review May 29, 2023 12:04
Copy link
Contributor

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🎉

@candunaj candunaj merged commit d6a3a89 into main May 29, 2023
7 checks passed
@candunaj candunaj deleted the scoped-class-classic-app branch May 29, 2023 12:09
@candunaj candunaj added enhancement New feature or request breaking labels May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants