Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added some typing #13

Closed
wants to merge 1 commit into from
Closed

Added some typing #13

wants to merge 1 commit into from

Conversation

KOLANICH
Copy link

@KOLANICH KOLANICH commented Dec 1, 2021 •
edited

Fixes #12

@soxofaan
Copy link
Owner

soxofaan commented Dec 1, 2021

Hi @KOLANICH thanks for the PR!
I'll try to address it later this week when I find some time

soxofaan added a commit that referenced this pull request Dec 2, 2021
@soxofaan
Issue #12 Add type annotations based on PR #13 by KOLANICH
4b7e087
@soxofaan
Copy link
Owner

soxofaan commented Dec 2, 2021

I already cherrypicked the basic annotations

I'm not a big fan of these type aliases

SymElementT = Union[str, int, bytes]
SymT = Union[Tuple[SymElementT, ...], SymElementT, "_EndOfFileSymbol"]
CodeT = Tuple[int, ...]
CodeTableT = Dict[SymT, CodeT]
SymTSeq = Iterable[SymT]

I would rather prefer to introduce some real (thin) containers (like namedtuples) instead of these cryptic aliases

@soxofaan soxofaan mentioned this pull request Dec 2, 2021
Open
@KOLANICH KOLANICH closed this Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Apply type annotations everywhere (in a 3.4-compatible way)
2 participants
@KOLANICH @soxofaan