Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply type annotations everywhere (in a 3.4-compatible way) #12

Open
KOLANICH opened this issue Dec 1, 2021 · 2 comments
Open

Apply type annotations everywhere (in a 3.4-compatible way) #12

KOLANICH opened this issue Dec 1, 2021 · 2 comments

Comments

@KOLANICH
Copy link

KOLANICH commented Dec 1, 2021

No description provided.

@KOLANICH KOLANICH changed the title Apply type annotatiins everywhere Apply type annotations everywhere (in a 3.4-compatible way) Dec 1, 2021
@KOLANICH KOLANICH mentioned this issue Dec 1, 2021
Closed
@soxofaan
Copy link
Owner

soxofaan commented Dec 1, 2021 •
edited
Loading

good idea,

nowadays I also use type annotations in new code,
but this project originally started as a python 2 compatible project

soxofaan added a commit that referenced this issue Dec 2, 2021
@soxofaan
Issue #12 Add type annotations based on PR #13 by KOLANICH
4b7e087
@soxofaan soxofaan mentioned this issue Dec 2, 2021
Open
@soxofaan
Copy link
Owner

soxofaan commented Dec 2, 2021

in a 3.4-compatible way

Side note: any reason you worry about 3.4 support? Testing is currently 3.5 and up:

dahuffman/.github/workflows/lint-and-test.yml

Line 14 in 218fbde

python-version: ["3.5", "3.6", "3.7", "3.8", "3.9", "3.10"]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added some typing KOLANICH-libs/dahuffman
2 participants
@soxofaan @KOLANICH