getObservableProperty doesn't return properties from Object.prototype

soxtoby · Nov 9, 2023 · 1103da8 · 1103da8
1 parent 5de5218
commit 1103da8
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 4 deletions.
diff --git a/packages/event-reduce-react/package.json b/packages/event-reduce-react/package.json
@@ -1,7 +1,7 @@
 {
   "name": "event-reduce-react",
   "description": "React integration for event-reduce: state management based on reducing observable events into state",
-  "version": "0.5.3",
+  "version": "0.5.4",
   "author": "Simon Oxtoby",
   "homepage": "https://github.com/soxtoby/event-reduce",
   "repository": {

diff --git a/packages/event-reduce/package.json b/packages/event-reduce/package.json
@@ -1,7 +1,7 @@
 {
   "name": "event-reduce",
   "description": "State management based on reducing observable events into state",
-  "version": "0.5.3",
+  "version": "0.5.4",
   "author": "Simon Oxtoby",
   "homepage": "https://github.com/soxtoby/event-reduce",
   "repository": {

diff --git a/packages/event-reduce/src/models.ts b/packages/event-reduce/src/models.ts
@@ -138,7 +138,10 @@ export function getObservableValues(instance: any): { [property: string]: Observ
 }
 
 export function getObservableProperty(prototype: any, key: string) {
-    return (getObservableProperties(prototype) || {})[key];
+    let observableProperties = getObservableProperties(prototype) || {};
+    return Object.hasOwn(observableProperties, key)
+        ? observableProperties[key]
+        : undefined;
 }
 
 function getOrAddObservableProperties(prototype: any) {

diff --git a/tsconfig.base.json b/tsconfig.base.json
@@ -2,7 +2,7 @@
   "compilerOptions": {
     "target": "es6",
     "module": "commonjs",
-    "lib": ["es2017", "dom"],
+    "lib": ["ES2022", "dom"],
     "jsx": "react",
     "strict": true,
     "noImplicitOverride": true,