Modernize package #280
Merged
Modernize package #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mschoettle
approved these changes
Mar 18, 2024
Comment on lines
53
to
60
| migrations.AlterIndexTogether( | ||
| name='crudevent', | ||
| index_together=set(), | ||
| ), | ||
| migrations.AddIndex( | ||
| model_name='crudevent', | ||
| index=models.Index(fields=['object_id', 'content_type'], name='easyaudit_c_object__82020b_idx'), | ||
| ), |
There was a problem hiding this comment.
This might not be necessary once #258 is merged
There was a problem hiding this comment.
Yeah it won't, but I'll solve the merge conflict once it lands.
|
@samamorgan looking good. But I'm not sure what the issue with |
This reverts commit 01dcf49. Fix version string
samamorgan
force-pushed
the
revert-279-revert-267-master
branch
from
ce3e32f
to
4eb61fe
Compare
Fixed the issues, including adding a new migration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #279