Fix CI #19
Merged
Fix CI #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OMG huge thanks!!! |
|
yeah, thanks @Jean-Beru for this work! |
|
sure |
|
done |
soyuka
reviewed
Jul 5, 2023
| $this->httpCallResultPool->store( | ||
| new HttpCallResult($this->mink->getSession()->getPage()->getContent()) | ||
| ); | ||
| if ($this->mink->getSession()->isStarted()) { |
There was a problem hiding this comment.
Note that this broke our test suite
There was a problem hiding this comment.
Same, and 2 other people experienced this issue too here : 8215019#r109969509
|
it looks like behat is now taking ~3hours and is broken lol |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR makes CI green again. But, to make it possible, note that:
@statusCodetag is skipped on Selenium tests since the driver doesn't supportgetStatusCodemethod@resttag is skipped on Selenium tests since the driver doesn't supportgetResponseHeadersmethod@jsonand@xmltags are skipped on Selenium tests since the response is wrapped inside HTML tagsThe two last points may not be a problem since this kind of tests doesn't need a Chrome nor Firefox to run since no javascript have to be executed.