review

soyuka · Nov 30, 2020 · cb7cf2b · cb7cf2b
1 parent 8769b25
commit cb7cf2b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/features/main/patch.feature b/features/main/patch.feature
@@ -41,7 +41,6 @@ Feature: Sending PATCH requets
       }
     }
     """
-    Then print last JSON response
     Then the response status code should be 200
     And the response should be in JSON
     And the header "Content-Type" should be equal to "application/ld+json; charset=utf-8"

diff --git a/src/Serializer/SerializerContextBuilder.php b/src/Serializer/SerializerContextBuilder.php
@@ -66,7 +66,7 @@ public function createFromRequest(Request $request, bool $normalization, array $
                 $context['api_allow_update'] = \in_array($method = $request->getMethod(), ['PUT', 'PATCH'], true);
 
                 if ($context['api_allow_update'] && 'PATCH' === $method) {
-                    $context[AbstractItemNormalizer::DEEP_OBJECT_TO_POPULATE] = $context[AbstractItemNormalizer::DEEP_OBJECT_TO_POPULATE] ?? true;
+                    $context['deep_object_to_populate'] = $context['deep_object_to_populate'] ?? true;
                 }
             }
 
@@ -108,7 +108,7 @@ public function createFromRequest(Request $request, bool $normalization, array $
         // TODO: We should always use `skip_null_values` but changing this would be a BC break, for now use it only when `merge-patch+json` is activated on a Resource
         foreach ($resourceMetadata->getItemOperations() as $operation) {
             if ('PATCH' === ($operation['method'] ?? '') && \in_array('application/merge-patch+json', $operation['input_formats']['json'] ?? [], true)) {
-                $context[AbstractItemNormalizer::SKIP_NULL_VALUES] = true;
+                $context['skip_null_values'] = true;
 
                 break;
             }