fixes

soyuka · Jul 3, 2024 · eb4ab82 · eb4ab82
1 parent caa72cf
commit eb4ab82
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 20 deletions.
diff --git a/src/OpenApi/Factory/OpenApiFactory.php b/src/OpenApi/Factory/OpenApiFactory.php
@@ -272,8 +272,7 @@ private function collectPaths(ApiResource $resource, ResourceMetadataCollection
             }
 
             $openapiOperation = $openapiOperation->withParameters($openapiParameters);
-
-            $existingResponses = $openapiOperation?->getResponses() ?: [];
+            $existingResponses = $openapiOperation->getResponses() ?: [];
             $overrideResponses = $operation->getExtraProperties()[self::OVERRIDE_OPENAPI_RESPONSES] ?? $this->openApiOptions->getOverrideResponses();
             if ($overrideResponses || !$existingResponses) {
                 // Create responses

diff --git a/src/Symfony/Bundle/Resources/config/api.xml b/src/Symfony/Bundle/Resources/config/api.xml
@@ -97,14 +97,6 @@
 
         <service id="api_platform.metadata.inflector" class="ApiPlatform\Metadata\Util\Inflector" public="false" />
 
-        <!-- Action -->
-        <service id="api_platform.action.exception" class="ApiPlatform\Action\ExceptionAction" public="true">
-            <argument type="service" id="api_platform.serializer" />
-            <argument>%api_platform.error_formats%</argument>
-            <argument>%api_platform.exception_to_status%</argument>
-            <argument type="service" id="api_platform.metadata.resource.metadata_collection_factory" />
-        </service>
-
         <!-- Cache -->
         <service id="api_platform.cache.route_name_resolver" parent="cache.system" public="false">
             <tag name="cache.pool" />

diff --git a/src/Symfony/Tests/Bundle/DependencyInjection/ApiPlatformExtensionTest.php b/src/Symfony/Tests/Bundle/DependencyInjection/ApiPlatformExtensionTest.php
@@ -175,7 +175,6 @@ public function testCommonConfiguration(): void
         $services = [
             'api_platform.action.documentation',
             'api_platform.action.entrypoint',
-            'api_platform.action.exception',
             'api_platform.action.not_found',
             'api_platform.api.identifiers_extractor',
             'api_platform.filter_locator',

diff --git a/tests/Behat/CoverageContext.php b/tests/Behat/CoverageContext.php
@@ -40,15 +40,8 @@ final class CoverageContext implements Context
     public static function setup(): void
     {
         $filter = new Filter();
-        if (method_exists($filter, 'includeDirectory')) {
-            $filter->includeDirectory(__DIR__.'/../../src');
-            self::$coverage = new CodeCoverage((new Selector())->forLineCoverage($filter), $filter);
-
-            return;
-        }
-
-        $filter->addDirectoryToWhitelist(__DIR__.'/../../src'); // @phpstan-ignore-line
-        self::$coverage = new CodeCoverage(null, $filter); // @phpstan-ignore-line
+        $filter->includeDirectory(__DIR__.'/../../src');
+        self::$coverage = new CodeCoverage((new Selector())->forLineCoverage($filter), $filter);
     }
 
     /**