Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vim: msg_id is a string #383

Merged
merged 1 commit into from May 28, 2022
Merged

vim: msg_id is a string #383

merged 1 commit into from May 28, 2022

Conversation

robertgzr
Copy link
Contributor

my msg_id's look like: b85, d39, ae0, etc.
and I get this error when using the vim plugin:

Error: cannot find maildir message by short hash "0" at "/path/to/my/INBOX"
Caused by:
0: cannot find maildir message id from short hash "0"
1: the short hash "0" matches more than one hash: 030598120934103c456ce08338886728, 06edb10a55efb89de45d8560aee33c8e

Signed-off-by: Robert Günzler r@gnzler.io

soywod
soywod requested changes May 21, 2022
View reviewed changes
Copy link
Owner

@soywod soywod left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for you contribution! Indeed, Maildir message ids are UUID strings and the Vim plugin was not up-to-date. Did you try with a regular IMAP account to see if your patch is backward compatible? I just left one comment, we can merge straight after.

vim/autoload/himalaya/msg.vim Outdated Show resolved Hide resolved
@robertgzr
vim: msg_id is a uuid string
e142261 
change the id parser according to the uuid spec:
https://datatracker.ietf.org/doc/html/rfc4122#section-3

and I get this error when using the vim plugin:

	Error: cannot find maildir message by short hash "0" at "/path/to/my/INBOX"
	Caused by:
	0: cannot find maildir message id from short hash "0"
	1: the short hash "0" matches more than one hash: 030598120934103c456ce08338886728, 06edb10a55efb89de45d8560aee33c8e

Signed-off-by: Robert Günzler <r@gnzler.io>
@robertgzr
Copy link
Contributor Author

Did you try with a regular IMAP account to see if your patch is backward compatible?

just did. works beautifully :)

@soywod soywod merged commit 0696f36 into soywod:development May 28, 2022
@soywod
Copy link
Owner

soywod commented May 28, 2022

Thanks a lot 🙏

@robertgzr robertgzr deleted the vim-msgid branch May 30, 2022 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soywod soywod soywod approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@robertgzr @soywod