Add mapillary to node detail view #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
January 13, 2017 15:58
By default the Mapillary content is invisible and only gets shown if it can provide content. Note the call to resize after applying the .visible class to the parent container: This is necessary to ensure that it gets rendered properly. Without it would be in an invalid state
Hoverbear
reviewed
Jan 20, 2017
| @@ -6,7 +6,7 @@ | |||
| config.cache_classes = true | |||
|
|
|||
| # Full error reports are disabled and caching is turned on | |||
| config.consider_all_requests_local = false | |||
| config.consider_all_requests_local = true | |||
There was a problem hiding this comment.
Ah good catch! I only enabled that to debug some things. This should be set to false obviously.
Hoverbear
approved these changes
Jan 20, 2017
This was set to true for debugging purposes and was only accidentally committed.
Hoverbear
approved these changes
Jan 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #480
This Pull Request adds Mapillary Street View for the Node Detail View additionally to Google Street View.
It is shown only if there's content available for the given latitude and longitude, otherwise it stays hidden.