Add Mapillary to detail pages

[holgerd]

Suggestion from the OSM forum:
Add Mapillary and OpenStreetView to detail pages
https://forum.openstreetmap.org/viewtopic.php?id=55958

Sounds like a good idea, maybe as an addition instead of a replacement of Google Streetview.

https://github.com/mapillary/mapillary-js seems to be free for non-profits and I did not find a widget option for OSV yet.

[holgerd]

I've created a mapillary user "sozialhelden" for this and put in in the shared 1p-vault.

[holgerd]

as step one, just Mapillary.

[holgerd]

@schultyy In case there is no mapillary photo, I now see a black rectangle. Example: https://staging.wheelmap.org/nodes/3017232832

Can the default background color of the widget be white or be omitteded completely?

[schultyy]

@holgerd Sure, I'll have a look into that. I'll try to not render it then if there's nothing to show.

[holgerd]

@schultyy Yes, not rendering if empty is a good soloution if that's possible!

[schultyy]

@holgerd On Staging there's now a version available which only renders Mapillary if there's actual content available. Otherwise it stays hidden.

[holgerd]

great! LGTM

[schultyy]

As discussed on Slack this will go into production beginning next week

[Svenyo]

@schultyy cc @holgerd Seems like the mapillary view we've implemented is not complete.
Peter from Mapillary told me in an email:

"There are however missing assets that can't be loaded like https://asset3.wheelmap.org/assets/stepper-play.svg that make the icons for navigation not be visible. Wold be great if you can fix that for a better integration :)"

[peterneubauer]

Yes, I'm seeing the missing assets in e.g. https://wheelmap.org/nodes/2370599905

[Svenyo]

Thanks @peterneubauer for commenting on this. Could you write down your further recommendations on how to fix the navigation icons?

[peterneubauer]

As you can see,
the icons are supposed to be under

https://asset3.wheelmap.org/assets/stepper-left.svg

etc, but give a 500 there.

Not sure how to fix it on your server but either move the MpaillaryJS script or the .svg assets somewhere so they can be found?

[schultyy]

So I found out why there's a 500:

2017/02/15 09:51:01 [error] 22604#0: *46493905 rewrite or internal redirection cycle while internally redirecting to "/assets/stepper-play.svg.html.html.html.html.html.html.html.html.html.html.html", client: <REDACTED>, server: asset0.wheelmap.org, request: "GET /assets/stepper-play.svg HTTP/1.1"

It appears to be a NGINX rule which is either missing or not working properly.

UPDATE:

On Staging we get 404 errors instead of 500.

[schultyy]

To check whether the problem is in the NGINX configuration or with wheelmap, I created a small example application with the snippet from the Mapillary-js GitHub page. There everything works just fine. Even though the browser receives HTTP 500 errors right now, they occur because the file cannot be found.
My solution on this is to copy over the missing assets from the GitHub repository into our assets directory to ensure they can be loaded properly.

[Svenyo]

Thanks, @schultyy, let's try this.

[1000miles]

@Svenyo We have deployed our fix to staging today. Can you please review the fix, e.g. via this node? https://staging.wheelmap.org/nodes/1229408775

Merci.

[Svenyo]

@1000miles Looks great! Can be deployed to prodution.

[schultyy]

Is in production now 🙆 .

[peterneubauer]

Great, looks good!