method Request::is_a_stop()

sozu-proxy · Mar 13, 2023 · c4dbf90 · c4dbf90
1 parent 4ec1b21
commit c4dbf90
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/bin/src/command/requests.rs b/bin/src/command/requests.rs
@@ -202,7 +202,7 @@ impl CommandServer {
                     offset = buffer.data().offset(i);
 
                     /*
-                    TODO: maybe we should put on Innerrequest the version field we had on CommandRequest: a u32 to track versionning
+                    TODO: maybe we should put on WorkerRequest the version field we had on CommandRequest: a u32 to track versionning
                     if requests.iter().any(|o| {
                         if o.version > PROTOCOL_VERSION {
                             error!("configuration protocol version mismatch: Sōzu handles up to version {}, the message uses version {}", PROTOCOL_VERSION, o.version);
@@ -1233,7 +1233,7 @@ impl CommandServer {
             worker_count += 1;
         }
 
-        let should_stop_main = request == Request::SoftStop || request == Request::HardStop;
+        let should_stop_main = request.is_a_stop();
 
         let mut command_tx = self.command_tx.clone();
         let thread_client_id = client_id.clone();

diff --git a/command/src/request.rs b/command/src/request.rs
@@ -158,6 +158,11 @@ impl Request {
         }
         proxy_destination
     }
+
+    /// True if the request is a SoftStop or a HardStop
+    pub fn is_a_stop(&self) -> bool {
+        self == &Self::SoftStop || self == &Self::HardStop
+    }
 }
 
 /// This is sent only from Sōzu to Sōzu