Updating RPM build script and spec file #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updating description and version in spec file. * Updating RPM build script, so you can run it from its current directory. * Adding .gitignore to exclude *.rpm files from commit. * Refactoring build script with BASH conventions.
* First one we behave like before - build sozu from the current checked-out sources, and it is the default one. * Second option will build the version defined in the spec file by downloading the corresponding tag archive from gituhb.
|
|
|
@Keruspe could you have a look at this? You being the build expert ;-) |
FlorentinDUBOIS
approved these changes
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two updates to the RPM build script file and spec.
Firstly, I updated the
rpm_build.shscript to work from inside theos-build/linux-rpm/directory. Before it worked only if it was moved toos-build/. Also, updated the version and summary of the spec file.The second commit is more of a nice-to-have but I think it's pretty useful. Now you can pass
--releaseoption torpm_build.shand it will build RPM packages from the tag archive (github) corresponding to the version defined insozu.spec. This is more safe method for production since it will 100% take the tagged sources from github and not your local code.I'm making this changes so we could more easily produce production builds of sozu for our company needs. I will be glad to keep maintain this section when need, and plan on contributing other ways as well.