Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(proxy): Add power_of_two and least_loaded to FromStr trait #868

Merged
merged 2 commits into from
Dec 20, 2022
Merged

fix(proxy): Add power_of_two and least_loaded to FromStr trait #868

merged 2 commits into from
Dec 20, 2022

Conversation

pims
Copy link
Contributor

@pims pims commented Dec 18, 2022

Also adjusted roundrobinto round_robin as described in bin/config.toml

# per cluster load balancing algorithm. The possible values are
# "round_robin", "random", "least_loaded" and "power_of_two". Defaults to "round_robin"
load_balancing = "round_robin"

@pims
fix(proxy): Add power_of_two and least_loaded to FromStr trait
7555d38 
Also adjusted `roundrobin`to `round_robin` as described in `bin/config.toml`

```toml
load_balancing = "round_robin"
```
@CLAassistant
Copy link

CLAassistant commented Dec 18, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

Keksoj
Keksoj approved these changes Dec 18, 2022
View reviewed changes
Copy link
Member

@Keksoj Keksoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! thank you!

@Wonshtrum can you have a look and approve as well?

FlorentinDUBOIS
FlorentinDUBOIS approved these changes Dec 18, 2022
View reviewed changes
Copy link
Collaborator

@FlorentinDUBOIS FlorentinDUBOIS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me as well

@pims @FlorentinDUBOIS
Update command/src/proxy.rs
1304914 
Co-authored-by: Florentin DUBOIS <florentin.dubois+github@hey.com>
@Keksoj Keksoj merged commit a0d0a67 into sozu-proxy:main Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlorentinDUBOIS FlorentinDUBOIS FlorentinDUBOIS approved these changes

@Keksoj Keksoj Keksoj approved these changes

@Wonshtrum Wonshtrum Awaiting requested review from Wonshtrum Wonshtrum is a code owner

@BlackYoup BlackYoup Awaiting requested review from BlackYoup

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pims @CLAassistant @FlorentinDUBOIS @Keksoj