Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update return for get_executable_path (freebsd) #894

Merged
merged 1 commit into from
Mar 1, 2023
Merged

Update return for get_executable_path (freebsd) #894

merged 1 commit into from
Mar 1, 2023

Conversation

jmingov
Copy link
Contributor

@jmingov jmingov commented Mar 1, 2023

The FreeBSD build was failing as the function was still returning String instead of an anyhow::Result<String>

@jmingov
Update return for get_executable_path (freebsd)
fbad528 
The FreeBSD build was failing as the function was still returning `String` instead of an `anyhow::Result<String>`
@CLAassistant
Copy link

CLAassistant commented Mar 1, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

Keksoj
Keksoj approved these changes Mar 1, 2023
View reviewed changes
Copy link
Member

@Keksoj Keksoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for that, we tend to overlook the build for other platforms

@Keksoj Keksoj added the package label Mar 1, 2023
@Keksoj Keksoj merged commit 76ae438 into sozu-proxy:main Mar 1, 2023
@jmingov jmingov deleted the patch-1 branch March 1, 2023 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Keksoj Keksoj Keksoj approved these changes

@FlorentinDUBOIS FlorentinDUBOIS Awaiting requested review from FlorentinDUBOIS FlorentinDUBOIS is a code owner

@Wonshtrum Wonshtrum Awaiting requested review from Wonshtrum Wonshtrum is a code owner

@BlackYoup BlackYoup Awaiting requested review from BlackYoup

Assignees

@jmingov jmingov

Labels
package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jmingov @CLAassistant @Keksoj