Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Updated] 1.7.10 FairyLights Crash #1121

Closed
Matthysse opened this issue Jan 4, 2018 · 7 comments
Closed

[Updated] 1.7.10 FairyLights Crash #1121

Matthysse opened this issue Jan 4, 2018 · 7 comments

Comments

@Matthysse
Copy link

The last version for play with FairyLights mod and Optifine is Optifine D6, since this version of optifine all new one are not compatible with FairyLights and the autor of fairy lights don't want to fix thix problem.

@sp614x
Copy link
Owner

sp614x commented Jan 10, 2018

More details needed:

  • crash report
  • error log (game output)
  • how to reproduce

@Matthysse
Copy link
Author

How to reproduce: Use the latest version of optifine (E7) and the latest version of fairylights (1.4.0) for minecraft 1.7.10. The latest version of optfine that work with FairyLight is D6.

Crash report:

crash-2018-01-10_18.52.12-client.txt

Logs:

fml-client-latest.log

@Matthysse Matthysse changed the title 1.7.10 FairyLights Crash [Updated] 1.7.10 FairyLights Crash Jan 10, 2018
@sp614x
Copy link
Owner

sp614x commented Jan 10, 2018

FairyLights crashes here: https://github.com/pau101/Fairy-Lights/blob/1.7.10/src/main/java/com/pau101/fairylights/client/renderer/ConnectionRenderer.java#L57

It tries to find the field EntityRenderer.currentFrustum which is not part of vanilla or OptiFine.
No idea where this field should come from or why it is missing.

@sp614x
Copy link
Owner

sp614x commented Jan 10, 2018

Maybe FairyLights tries to patch the EntityRenderer.renderWorld() at the place where the Frustum is created.

Here is how this place has changed between D6 and D7:

image

@sp614x
Copy link
Owner

sp614x commented Jan 10, 2018

This should be fixed in FairyLights, OptiFine can't change how the code at this place works.

@pau101
Copy link

pau101 commented Jan 11, 2018

This is an issue I receive reports on fairly regularly and it is not something I'm going to be releasing a patch for. I simply can't hold the routine to update old asm of mine for other mod releases to maintain compatibility after I've stopped development on that Minecraft version.

@sp614x
Copy link
Owner

sp614x commented Jan 11, 2018

The problem can't be fixed in OptiFine as FairyLights is the one actively patching the class.

@sp614x sp614x closed this as completed Jan 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants